Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] 유사견적 추천 후 요약 데이터 제공 #390

Merged
merged 14 commits into from
Aug 22, 2023
Merged

[BE] 유사견적 추천 후 요약 데이터 제공 #390

merged 14 commits into from
Aug 22, 2023

Conversation

tank3a
Copy link
Collaborator

@tank3a tank3a commented Aug 21, 2023 •
edited
Loading

  • 버그 수정
  • 기능 개발
  • 리팩토링
  • 문서 변경
  • 기타... 설명:

📝 설명

유사견적 데이터 검색 및 견적 데이터 요약정보 제공 API생성. 테스트 코드 작성. 예외처리 방식 수정

✨ 특이 사항

파이썬 프로그램 접근을 위해 test쪽 yml파일을 제거할 예정입니다.
코드 충돌로 상당부분 변경했습니다.

🖼️ 스크린샷 (선택 사항)

@tank3a tank3a added backend 백엔드 구현 sub task 메인 테스크에 종속적인 서브 테스크로 설정 labels Aug 21, 2023
@tank3a tank3a requested a review from dydwo0740 August 21, 2023 18:19
@tank3a tank3a self-assigned this Aug 21, 2023
@kimdaye77 kimdaye77 marked this pull request as draft August 22, 2023 01:05
@tank3a tank3a marked this pull request as ready for review August 22, 2023 05:59
@github-actions
Copy link

📊 테스트 커버리지 결과

Overall Project 83.37% -4.06% 🍏
Files changed 64.97% ❌

File Coverage
ModelController.java 100% 🍏
CarController.java 100% 🍏
QuoteRepository.java 100% 🍏
ColorService.java 98.73% 🍏
ModelService.java 98.14% 🍏
OptionService.java 97.71% 🍏
QuoteService.java 94.19% -5.81% 🍏
ErrorCode.java 92.59% 🍏
OptionRepository.java 91.02% 🍏
QuoteDataDto.java 90.41% 🍏
QuoteInfoDto.java 89.64% 🍏
HistorySearchDto.java 89.23% -10.77% 🍏
QuoteController.java 85.19% -14.81% 🍏
HistoryShortDto.java 77.63% -22.37% ❌
CarService.java 69.77% -4.36% ❌
GlobalExceptionHandler.java 12.28% -59.65% ❌
RecommendConnector.java 1.92% -98.08% ❌
InvalidDataException.java 0% ❌
ServerException.java 0% ❌

dydwo0740
dydwo0740 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@dydwo0740 dydwo0740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD

@dydwo0740 dydwo0740 merged commit cab78a2 into dev Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dydwo0740 dydwo0740 dydwo0740 approved these changes

Assignees

@tank3a tank3a

Labels
backend 백엔드 구현 sub task 메인 테스크에 종속적인 서브 테스크로 설정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 유사 견적 요약정보(막대그래프) 제공
2 participants
@tank3a @dydwo0740